<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">29. aug. 2014 kl. 17:04 skrev Harri Pitkänen <<a href="mailto:hatapitk@iki.fi">hatapitk@iki.fi</a>>:<br><br><blockquote type="cite">On Friday 29 August 2014 10:21:24 Sjur Moshagen wrote:<br><blockquote type="cite">I am building for LO 3.6-4.0 because you in an earlier e-mail said we should<br>make that one work with hfst before we moved on to newer versions :)<br></blockquote><br>I am trying to avoid the need to re-build libreoffice-voikko on Windows <br>because my old Windows laptop has serious hardware problems. It may take hours <br>of work and many reboots to get a single build out.<br></blockquote><div><br></div><div>ok :)</div><br><blockquote type="cite">The bugs we had earlier were in ZHFST support of libvoikko. I wanted to get <br>those fixed first because they were more serious and it was easy for me to <br>produce and test new builds of libvoikko (I could do that on my Linux desktop <br>that has no stability problems).<br></blockquote><div><br></div><div>My experience is that the zhfst support has stabilised quite a lot during the last spring, and I have not had any issues related to the hfst-ospell library in quite a while. Whenever there has been issues, they have lately always been caused by problematic fst’s (one could of course argue that hfst-ospell should be able to detect such fst’s and just cleanly report that it can’t deliver the requested service).</div><br><blockquote type="cite">But if we now have to fix anything in libreoffice-voikko it does not matter if <br>we move to the latest version or patch the old one; I have to re-build it <br>anyway.<br></blockquote><div><br></div><div>ok.</div><div><br></div><blockquote type="cite"><blockquote type="cite">Anyway, I have now applied the following change:<br><br><a href="https://github.com/voikko/libreoffice-voikko/commit/5a8e3ae1df60ef1ae86e6aba">https://github.com/voikko/libreoffice-voikko/commit/5a8e3ae1df60ef1ae86e6aba</a><br>ed6c690e8277df8e<br><br>to the 3.4.1 source code, and rebuilt the oxt against the LO 3.6 SDK.<br>Unfortunately the resulting files/binaries in the oxt are exactly the same<br>as the old one - no change whatsoever reported by subversion when I tried<br>to commit the new oxt template to our svn repository.<br><br>How come? Is this code completely unused by the older versions of LO (SDK)?<br></blockquote><br>It seems you picked the wrong commit…</blockquote><div><br></div><div>Sorry - I looked too quickly at the dates, and missed the correct one :(</div><br><blockquote type="cite">Between my original mail to this list <br>and your testing there were two other commits to master and you picked the <br>last one. That commit has no effect on anything earlier than LibreOffice 4.4. <br>The relevant commit is 10d58ff757f65f499fdad8a77dbc5651789f2bc2 (Switch to <br>passive component registration).<br></blockquote><div><br></div><div>I did rebuild both a patched 3.4.1 (tentatively upped to 3.4.2) for LO 3.6-4.0, and the latest git trunk for LO 4.1+.</div><div><br></div><div>The results are pretty clear: there are no uninstallation issues anymore. That is, for all of LO 3.6-4.1 I have working, reasonably stable oxt’s for sme, kal and fin. They all install and uninstall the way they should, even when there are open documents containing texts in the oxt speller language. Thanks for the code changes :)</div><br><blockquote type="cite">On Friday 29 August 2014 11:10:36 Sjur Moshagen wrote:<br><blockquote type="cite">I just recompiled the newest git sources against the LO 4.1 SDK, and the<br>resulting OXT contained modified files (and one new file) compared to what<br>I had in svn. Thus it seems that your change didn’t mean anything to the<br>older SDK.<br></blockquote><br>This was probably not because of the SDK version but the fact that the newest <br>sources also contain the passive component registration changes.<br><br>Anyway: did you try this OXT, is it possible to uninstall it cleanly?</blockquote><div><br></div><div>Yes, see above.</div><br><blockquote type="cite">If it <br>is, I will try to find to old Windows laptop and start rebooting it, hoping to <br>have a complete build before it crashes for the last time and no longer boots <br>:)<br></blockquote><div><br></div><div>:)</div><br><blockquote type="cite"><blockquote type="cite">Do we need to support LO older than 4.1?<br></blockquote><br>In my opinion no, we don't need to do that anymore. 4.1 and earlier are no <br>longer supported by LibreOffice upstream developers. So unless one has a <br>separate support contract or is using a Linux distribution with long term <br>support one should upgrade to at least 4.2 to get security fixes.</blockquote><br>This is the big next issue for me: the LO 4.1 OXT does not work with neither LO 4.2 or 4.3. It installs cleanly, but as soon as one opens the Voikko preferences pane, it is completely empty (see attached screenshot). It doesn’t help to build the OXT against the LO 4.2 or 4.3 SDK’s. The OXT is built on MacOSX 10.6 to ensure backwards compatibility at least as far back as that. And there is no issue with LO 4.1, which AFAIK uses the same API as 4.2 and 4.3.<div><br></div><div>If we can fix this, we are a major step towards a release candidate.</div><div><br></div><div>Sjur</div><div><img apple-inline="yes" id="66E560A5-EA40-4680-90FB-92DEECDF35A3" height="239" width="320" apple-width="yes" apple-height="yes" src="cid:F51C9929-AF6E-4389-BB4F-327C8CC6A16A"></div></body></html>