[libvoikko] different output via voikkogc and libreoffice-voikko

Harri Pitkänen hatapitk at iki.fi
Tue Oct 1 17:37:27 EEST 2013

On Tuesday 01 October 2013 13:54:46 Francis Tyers wrote:
> As far as I'm concerned, it should be ok. There are the following
> caveats:
> * The code is pretty ropey at the moment. It works, but no-one apart
> from me has tested it as working. There is some stuff hardcoded there
> (in the V4DictionaryLoader) that we are likely to want to change.

No problem. You can always change this and other stuff that is within 
VISLCG3_CPP_FILES without any risk of breaking other parts of the library.

> * There is a lot of debugging stuff in there that you might want to
> remove during the merge.
> * The grammar checking now depends on the latest SVN of hfst-ospell to
> work. This is because previous versions did not have a lookup() method.

I think this is fine.

> There is one show stopper:
> * Grammar checking for Finnish is currently broken. I should fix this.
> So, I think the best thing would be for me to fix Finnish, and then do
> the merge. Feel free to take a look at the code and give me suggestions,
> my code has rarely been described as elegant.

Sounds good. The code looks fine too. I'll have another look when it is time 
to merge it.


More information about the Libvoikko mailing list